Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add layer-TSOS compatibility check in LayerMeasurements #42320

Merged
merged 1 commit into from
Jul 27, 2023
Merged

add layer-TSOS compatibility check in LayerMeasurements #42320

merged 1 commit into from
Jul 27, 2023

Conversation

missirol
Copy link
Contributor

PR description:

This PR includes a possibile solution for the issue discussed in #40174 (see that issue for details), thanks to suggestions from @cms-sw/tracking-pog-l2.

#42318 contains a different solution for the same issue. The two PRs are not mutually exclusive (in principle, both could be integrated).

In this PR, a check is added to LayerMeasurements in order to skip TrajectoryStateOnSurface objects whose global position is well outside the detector volume. The rationale of this check was discussed in #40174 (comment).

PR validation:

Manual checks with the reproducers in #40174 (comment) and #40174 (comment).

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

TBD

@missirol missirol mentioned this pull request Jul 20, 2023
Merged
@cmsbuild cmsbuild added this to the CMSSW_13_3_X milestone Jul 20, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42320/36348

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • TrackingTools/MeasurementDet (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @bellan, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol missirol force-pushed the devel_issue40174_fixLayerMeas branch from 8fc4bef to d495adf Compare July 20, 2023 11:57
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42320/36349

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #42320 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Jul 20, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7ff3f/33805/summary.html
COMMIT: d495adf
CMSSW: CMSSW_13_3_X_2023-07-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42320/33805/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 12 lines from the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3197149
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3197126
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+reconstruction
Fix for HLT crash by requiring a reasonable projected rechit position which is not far away from CMS.
No changes observed in comparisons, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link
Contributor Author

Given the changes in data-taking schedule, I guess a backport to 13_0_X is not so useful anymore (assuming it would have been accepted). I would still backport this to 13_2_X, unless somebody objects.

@missirol missirol mentioned this pull request Jul 26, 2023
Merged
@rappoccio
Copy link
Contributor

+1

I think it doesn't hurt to have the 13_0_X backport as well, unless there are some conflicts.

@cmsbuild cmsbuild merged commit 675d612 into cms-sw:master Jul 27, 2023
This was referenced Jul 29, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rappoccio rappoccio rappoccio left review comments

@slava77 slava77 slava77 left review comments

@mmusich mmusich mmusich left review comments

Assignees
No one assigned
Labels
code-checks-approved fully-signed orp-approved reconstruction-approved tests-approved tracking
Projects
None yet
Milestone
CMSSW_13_3_X
Development

Successfully merging this pull request may close these issues.
6 participants
@missirol @cmsbuild @mmusich @mandrenguyen @rappoccio @slava77